Fix image ID parsing in modern Docker #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f997a6d to
73875bb
Compare
7e13c1b to
1149ffc
Compare
1149ffc to
cadd75b
Compare
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 55.72% 52.85% -2.87%
==========================================
Files 31 33 +2
Lines 3180 3557 +377
==========================================
+ Hits 1772 1880 +108
- Misses 1408 1677 +269
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Upgrades
psycopg2-binaryandpytestto get tests passing again withmodern Python.
Modifies
docker buildcommands to get the built image ID via--iidfilevs parsing the shell command output.
adds
--platform linux/amd64todocker runanddocker buildcommands,until we get support for
arm64sorted out.fixes failure when GCP credentials aren't configured running in local mode.