Fix progress bar interactions in caliban run subprocesses
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 46.17% 46.42% +0.24%
==========================================
Files 17 17
Lines 2733 2753 +20
==========================================
+ Hits 1262 1278 +16
- Misses 1471 1475 +4
Continue to review full report at Codecov.
|
sritchie
commented
Jun 26, 2020
ajslone
approved these changes
Jun 26, 2020
Contributor
ajslone
left a comment
There was a problem hiding this comment.
LGTM, nice work on this, as your fixes are pretty subtle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes that allow us to use
caliban runto execute scripts with (single) progress bars or other updating progress meters that use carriage returns to modify lines.It's not PERFECT — if you have a progress bar and use
tqdm.write("HI!")inside, for example, you'll trigger a newline, instead of the nice, flowing-upward output above the inner progress bar that you get when you runtqdmlocally. But that is a challenge for another day.I was able to package this pretty cleanly, I think, into
TqdmFile, but it does require some fiddling incapture_outputas well.