Project restructure to make it easier to implement more backends #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23281bc to
76fe3e0
Compare
added 3 commits
July 11, 2020 13:17
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 46.52% 47.57% +1.04%
==========================================
Files 17 26 +9
Lines 2764 2825 +61
==========================================
+ Hits 1286 1344 +58
- Misses 1478 1481 +3
Continue to review full report at Codecov.
|
Contributor
Author
|
@ajslone , I've tested Thank you! |
ajslone
approved these changes
Jul 13, 2020
Contributor
ajslone
left a comment
There was a problem hiding this comment.
LGTM. This re-org should make the structure of the project clearer.
| # ---------------------------------------------------------------------------- | ||
| def _get_caip_job_api() -> Any: | ||
| return discovery.build('ml', 'v1', cache_discovery=False).projects().jobs() | ||
| def _get_caip_job_api(credentials_path: Optional[str] = None) -> Any: |
| import caliban.util as u | ||
| import caliban.docker.build as b | ||
| import caliban.history.cli | ||
| import caliban.platform.cloud.core as cloud |
Contributor
There was a problem hiding this comment.
Definitely like the platform.xxx structure better here.
| # credentials. | ||
| credentials = gcloud_auth_credentials() | ||
|
|
||
| credentials = ua.gcloud_credentials(credentials_path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors:
caliban.configintocaliban.configandcaliban.config.experimentcaliban.utilbecomescaliban.utilandcaliban.util.{argparse, auth, fs, tqdm}caliban.cloud.*becomescaliban.platform.cloud.*caliban.dockerbecomescaliban.docker.{build, push}andcaliban.platform.{run, shell, notebook}The tests are also split accordingly.
I snuck in ONE bugfix that appeared during testing. I moved our method of generating credentials from
gcloud auth loginover tocaliban.util.authso that I could reuse it in the caliban history API. We had one spot where we were callingdiscovery.buildand NOT passing any credentials, which threw an error when the user didn't haveGOOGLE_APPLICATION_CREDENTIALSspecified.I also removed unused imports and sorted imports wherever I could.
Why?
The project needed it; specifically this is going to make it easier to increase test coverage, and to get the
.calibanconfig.jsoncode working with a proper schema, so that we can start to add options there.I really want to make the platforms pluggable, and sorting them out into separate modules is the first step.