Custom base image support in calibanconfig #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ajslone @sagravat one thought... we COULD allow the user to provide a format string, like And then we could splice in the job mode at runtime. Is this good? Then it's easier to specify this from the command line. or Thoughts? |
ajslone
approved these changes
Jul 15, 2020
Contributor
ajslone
left a comment
There was a problem hiding this comment.
LGTM, this will enable many use cases that have been painful or impossible before.
| base_image_fn = base_image_id | ||
|
|
||
| base_image = base_image_fn(job_mode) | ||
| base_image = c.base_image(caliban_config, job_mode) or base_image_id(job_mode) |
|
LGTM, +1 |
Merged
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 49.51% 50.51% +1.00%
==========================================
Files 28 28
Lines 2872 2894 +22
==========================================
+ Hits 1422 1462 +40
+ Misses 1450 1432 -18
Continue to review full report at Codecov.
|
This was referenced Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets us started with an approach for custom base images; this is inspired by @sagravat's work in #20, but I had changed so much about the project organization in the meantime that it felt appropriate to whip up this example.
@sagravat, would love your thoughts on how this feels to use!
The user can supply a
"base_image"entry into.calibanconfig.jsonthat can either be:Any of the DLVM images will automatically expand. I took slight liberty by forcing the job mode into the name and adding a prefix. So we now have these DLVM options:
Let me know what you think!