-
Notifications
You must be signed in to change notification settings - Fork 67
Upgrade uv-metrics tutorial #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ajslone , this should be a good test of the MLFlow integration you're working on! |
|
@ajslone please feel free to merge if you think this looks good. |
ajslone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of questions.
| @@ -1,9 +1,2 @@ | |||
| # Get it done | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So uv/master is not compatible with this? I thought those changes were in now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, sorry to leave this in. yes, it is now compatible
|
|
||
| with r.start_run(): | ||
| r.log_params({ | ||
| with uv.start_run(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer a context manager, right?
|
@ajslone this should work with UV master, so maybe for now confirm that against your work - would you mind giving it an update and merge if it seems like it will work? |
|
There are a couple of issues right now, the primary one is that the parameters do not get reported using |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 51.41% 51.68% +0.26%
==========================================
Files 30 30
Lines 2970 2972 +2
==========================================
+ Hits 1527 1536 +9
+ Misses 1443 1436 -7
Continue to review full report at Codecov.
|
This PR upgrades the tutorial to be compatible with the latest changes in https://pypi.org/project/uv-metrics/.