Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sritchie
Copy link
Contributor

@sritchie sritchie commented Aug 4, 2020

This PR upgrades the tutorial to be compatible with the latest changes in https://pypi.org/project/uv-metrics/.

@sritchie sritchie requested a review from ajslone August 4, 2020 13:54
@sritchie
Copy link
Contributor Author

sritchie commented Aug 4, 2020

@ajslone , this should be a good test of the MLFlow integration you're working on!

@sritchie
Copy link
Contributor Author

sritchie commented Aug 4, 2020

@ajslone please feel free to merge if you think this looks good.

Copy link
Contributor

@ajslone ajslone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of questions.

@@ -1,9 +1,2 @@
# Get it done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So uv/master is not compatible with this? I thought those changes were in now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, sorry to leave this in. yes, it is now compatible


with r.start_run():
r.log_params({
with uv.start_run():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer a context manager, right?

@sritchie
Copy link
Contributor Author

sritchie commented Aug 4, 2020

@ajslone this should work with UV master, so maybe for now confirm that against your work - would you mind giving it an update and merge if it seems like it will work?

@ajslone
Copy link
Contributor

ajslone commented Aug 4, 2020

There are a couple of issues right now, the primary one is that the parameters do not get reported using uv.report_params as the active reporter has not been set to an MLFlowReporter, so they are being set on a NullReporter. I can push a change for this.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #72 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   51.41%   51.68%   +0.26%     
==========================================
  Files          30       30              
  Lines        2970     2972       +2     
==========================================
+ Hits         1527     1536       +9     
+ Misses       1443     1436       -7     
Impacted Files Coverage Δ
caliban/util/fs.py 89.62% <0.00%> (-0.95%) ⬇️
caliban/platform/gke/util.py 72.90% <0.00%> (+2.51%) ⬆️
caliban/util/auth.py 76.19% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9dd99...0998d91. Read the comment docs.

@ajslone ajslone merged commit 2e54304 into master Aug 6, 2020
@ajslone ajslone deleted the sritchie/upgrade_tutorial branch August 6, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants