minor bug fixes for gke #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
approved these changes
Aug 13, 2020
Contributor
sritchie
left a comment
There was a problem hiding this comment.
Excellent. How did you track these down?
| self._core_api = None | ||
| self._batch_api = None | ||
| self._apps_api = None | ||
| self._gke_cluster: Optional[GKECluster] = None |
Contributor
There was a problem hiding this comment.
nice, didn't realize you could type variables inline.
Contributor
Author
There was a problem hiding this comment.
now that we require python >= 3.6 we can!
Contributor
|
@ajslone also do previous tests cover these? Is there any easy way to lock in this behavior with tests, or do the types cover it? |
Contributor
Author
|
I need to add tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some minor bugfixes for the gke backend.