This repository was archived by the owner on Dec 9, 2025. It is now read-only.
fix: Delete singleton links if they are removed #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a link is deleted as the last link the driver will never reconcile and leave it in the resource slice. Ensure that this does not happen since that could lead to bad assignments by the scheduler.
michaelasp
commented
Jul 11, 2025
aojea
approved these changes
Jul 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a link is deleted as the last link the driver will never reconcile and leave it in the resource slice. Ensure that this does not happen since that could lead to bad assignments by the scheduler. Can easily replicate the issue by creating a cluster and adding then removing a link.
Fixes #155