Add gotpm read pcr. #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevenrutherford
commented
Sep 19, 2019
- Adds new command and subcommands for read and read pcr.
- Adds misc.go to store oddball wrappers for commands like tpm2.ReadPCRs.
Member
|
Two quick things,
|
josephlr
reviewed
Sep 19, 2019
josephlr
reviewed
Sep 19, 2019
josephlr
reviewed
Sep 19, 2019
Contributor
Author
(In the future it's probably easier to have changes be threaded conversations or whatever github calls them, so we can make sure everything is resolved) I've done this (and I think it improves usability), but I'm a little weary, since this leads to inconsistent defaults for flags. |
ac64d93 to
3955ecf
Compare
* Adds new command and subcommands for read and read pcr. * Adds misc.go to store oddball wrappers for commands like tpm2.ReadPCRs.
3955ecf to
9b5c449
Compare
6d6e855 to
7263fc0
Compare
josephlr
reviewed
Sep 28, 2019
| @@ -0,0 +1,46 @@ | |||
| package tpm2tools | |||
Member
There was a problem hiding this comment.
Can we just name this file pcr.go as it only does pcr shit.
Contributor
Author
There was a problem hiding this comment.
Ack: will do this as a final step, but won't until we're done with the rest (to avoid marking the entire file as needing to be reviewed).
9c31b7c to
d0f8cfc
Compare
d0f8cfc to
90c8c9c
Compare
josephlr
reviewed
Sep 28, 2019
josephlr
reviewed
Sep 28, 2019
josephlr
approved these changes
Oct 2, 2019
Member
josephlr
left a comment
There was a problem hiding this comment.
Fixed the test and some formatting weirdness.
josephlr
pushed a commit
to josephlr/go-tpm-tools
that referenced
this pull request
Oct 2, 2019
* Adds new command and subcommands for read and read pcr. * Adds pcr.go to store wrappers for commands like tpm2.ReadPCRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.