Add TpmSigner #56
Merged
Add TpmSigner #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
reviewed
Oct 25, 2019
Member
josephlr
left a comment
There was a problem hiding this comment.
Nice start on this. I think it's a good idea to only do PKCS#1 v1.5 RSA signing first, as it lets us get framework in place.
However, I think this PR should add a GetSigner() method to Key, I go into more detail in my review comments, but which error checking we do where is important.
josephlr
approved these changes
Nov 19, 2019
Member
josephlr
left a comment
There was a problem hiding this comment.
Nice job, just fix a few nits and rebase this change, and we should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TpmSigner only supports RSA PKCS#1 v1.5 signing. Subsequent PRs will add PSS and ECC support.
There will also be a PR for adding a (k *Key) GetSigner function, which will check that the Key is appropriate to be used as a Signer.
Also enables SHA512 in the simulator. The simulator told me to set MAX_CONTENT_SIZE to 1360 when I tried to run it after enabling SHA512.