Add server and client Import workflows #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenDHillier
commented
Sep 4, 2019
c8aed43 to
330775f
Compare
Merge changes
330775f to
be47681
Compare
josephlr
reviewed
Sep 10, 2019
josephlr
reviewed
Sep 12, 2019
Member
josephlr
left a comment
There was a problem hiding this comment.
Can you be sure to run go fmt on this PR, there's some formatting weirdness.
josephlr
reviewed
Sep 13, 2019
Member
josephlr
left a comment
There was a problem hiding this comment.
Nice work, this is almost done! Again, always be sure to run go fmt ./... on the repo before pushing.
josephlr
reviewed
Sep 17, 2019
Member
josephlr
left a comment
There was a problem hiding this comment.
Please rebase onto master
Also run:
goimports -w **/*.goee3d979 to
f0418c9
Compare
BenDHillier
added a commit
to BenDHillier/go-tpm-tools
that referenced
this pull request
Sep 19, 2019
Add server and client Import workflows (google#36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add server.CreateImportRequest for a server side Import workflow.
Add tpm2tools.Import for a client side Import workflow.
Add import testing in server/import_test.go. Only add the one test as there's no way to test the server side and client side workflows separately (Need to run client side to verify server side worked correctly, and vice versa).
Also add a function for creating tpm2.Public objects from crypto.PublicKey's and a corresponding test.