Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(storage): fix append edge cases #12074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2025
Merged

fix(storage): fix append edge cases #12074

merged 4 commits into from
Apr 29, 2025

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Apr 28, 2025 •
edited
Loading

  • Fix the validation for generation being included.
  • Fix a case where the error was not being picked up during append takeover.
  • Fix a hang that can occur when Flush returns an error.
  • Add an integration test for these issues

@tritone
fix(storage): fix append edge cases
ecbd246 
Fix the validation for generation being included. Fix a case
where the error was not being picked up during append takeover.
Add an integration test for these issues
@tritone tritone requested review from a team as code owners April 28, 2025 20:49
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 28, 2025
meet2mky
meet2mky reviewed Apr 29, 2025
View reviewed changes
BrennaEpp
BrennaEpp reviewed Apr 29, 2025
View reviewed changes
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2025
@BrennaEpp BrennaEpp merged commit 0eee1f9 into googleapis:main Apr 29, 2025
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2025
@release-please release-please bot mentioned this pull request Apr 29, 2025
Merged
2FaceS-bit pushed a commit to 2FaceS-bit/google-cloud-go that referenced this pull request May 12, 2025
@tritone @2FaceS-bit
fix(storage): fix append edge cases (googleapis#12074)
6fa4017 
* fix(storage): fix append edge cases

Fix the validation for generation being included. Fix a case
where the error was not being picked up during append takeover.
Add an integration test for these issues

* fix flush hang

* add another takeover case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennaEpp BrennaEpp BrennaEpp approved these changes

+1 more reviewer

@meet2mky meet2mky meet2mky left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tritone @BrennaEpp @meet2mky