fix(storage): fix append writer hang #12201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a Flush call, we weren't correctly tracking the pipe reader to close to signal to Write that an error had happened. Fixes that issue and adds another flush to the test, which triggers the hang without this fix.
BrennaEpp
reviewed
May 5, 2025
BrennaEpp
approved these changes
May 6, 2025
2FaceS-bit
pushed a commit
to 2FaceS-bit/google-cloud-go
that referenced
this pull request
May 12, 2025
After a Flush call, we weren't correctly tracking the pipe reader to close to signal to Write that an error had happened. Fixes that issue and adds another flush to the test, which triggers the hang without this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a Flush call, we weren't correctly tracking the pipe reader to close to signal to Write that an error had happened. Fixes that issue and adds another flush to the test, which triggers the hang without this fix.