Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add support for restore token #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2024
Merged

feat: add support for restore token #2548

merged 8 commits into from
Oct 29, 2024

Conversation

thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #restoreToken

@thiyaguk09 thiyaguk09 requested review from a team as code owners October 25, 2024 07:03
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Oct 25, 2024
@thiyaguk09 thiyaguk09 changed the title feat: adds support for restore token feat: add support for restore token Oct 25, 2024
@thiyaguk09 thiyaguk09 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2024
@thiyaguk09
Merge pull request #7 from thiyaguk09/support-for-restore-token
a36d539 
Merge branch 'googleapis:main' into support-for-restore-token
ddelgrosso1
ddelgrosso1 reviewed Oct 25, 2024
View reviewed changes
src/file.ts
name: string;

generation?: number;
restoreToken?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to have this field as both a class level and metadata level field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that in some scenarios, a refresh token is associated with a specific generation ID. To ensure consistent behavior and avoid potential issues, I've implemented the refresh token handling in a way that aligns with the generation ID concept. This approach will help maintain data integrity and security.

@ddelgrosso1
Copy link
Contributor

My understanding is that the restore token would be returned on a call to delete. Is that going to be a separate PR or should it be included here?

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2024
@thiyaguk09
Copy link
Contributor Author

My understanding is that the restore token would be returned on a call to delete. Is that going to be a separate PR or should it be included here?

I'm currently focused on implementing support for restore tokens in the get, list, and restore operations.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2024
@ddelgrosso1 ddelgrosso1 merged commit 8241e91 into googleapis:main Oct 29, 2024
16 checks passed
@release-please release-please bot mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thiyaguk09 @ddelgrosso1