fix: add default value in SchemaField.from_api_repr() #2115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After our discussion, I don't think we should add python-bigquery/google/cloud/bigquery/schema.py Lines 191 to 192 in 9c50418 |
tswast
approved these changes
Jan 17, 2025
chalmerlowe
pushed a commit
that referenced
this pull request
Jan 22, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing googleapis/python-bigquery-pandas#854, do not merge until yanking 3.28.0 is complete.
In https://github.com/googleapis/python-bigquery/pull/2097/files#diff-dc8e320384c6a5d2b65e1e05c4853b853575618ff4706a6f2c74b9363d49ea14 in method
SchemaField.from_api_repr(), we no longer set a default value formodeif it's not provided in the API representation, causing tests to fail in pandas-gbq. This PR adds it back.