Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add logs to warn when not all 3 files (mod, info and zip) are present  #1171

@arschles

Description

@arschles

Is your feature request related to a problem? Please describe.

The file system storage currently checks for all three files (.mod, .zip, .info) exist and fails any one endpoint if they don't all exist. This can be problematic if, for some reason, 1/3 or 2/3 of the files exist. In this case, Athens will "fall back" to downloading the module from the VCS and overwriting it in its storage.

That's not an optimal solution, but without a larger refactoring, it's the best we can do

Describe the solution you'd like

We should clearly log when we run into a situation when a module doesn't have all 3 files present. The log should be a "warning" with detailed information on why this happens and what Athens is doing to fix it (i.e. falling back to the VCS), and what that means (the module might get overwritten)

Describe alternatives you've considered

A larger refactor of how files are stored on disk

Additional context

This is a follow-up from #1143 (comment).

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGreat issues for new Athenians to work on!

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions