Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Add Vary header when allowedOrigins is * (#114)" #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2018
Merged

Revert "Add Vary header when allowedOrigins is * (#114)" #122

merged 1 commit into from
Apr 16, 2018

Conversation

@elithrar
Copy link
Contributor

@elithrar elithrar commented Apr 16, 2018

This reverts commit 9327cfd.

=== RUN   TestDefaultCORSHandlerReturnsOkWithOrigin
--- FAIL: TestDefaultCORSHandlerReturnsOkWithOrigin (0.00s)
panic: runtime error: index out of range [recovered]
	panic: runtime error: index out of range
goroutine 16 [running]:
testing.tRunner.func1(0xc42007c0d0)
	/home/travis/.gimme/versions/go1.8.linux.amd64/src/testing/testing.go:622 +0x55f
panic(0x81b720, 0xa3e440)
	/home/travis/.gimme/versions/go1.8.linux.amd64/src/runtime/panic.go:489 +0x2f0
github.com/gorilla/handlers.(*cors).ServeHTTP(0xc4200c41b0, 0xa19840, 0xc42007a0c0, 0xc4200ac100)
	/home/travis/gopath/src/github.com/gorilla/handlers/cors.go:109 +0x4f0
github.com/gorilla/handlers.TestDefaultCORSHandlerReturnsOkWithOrigin(0xc42007c0d0)
	/home/travis/gopath/src/github.com/gorilla/handlers/cors_test.go:31 +0x296
testing.tRunner(0xc42007c0d0, 0x8869a0)
	/home/travis/.gimme/versions/go1.8.linux.amd64/src/testing/testing.go:657 +0x108
created by testing.(*T).Run
	/home/travis/.gimme/versions/go1.8.linux.amd64/src/testing/testing.go:697 +0x544
exit status 2
FAIL	github.com/gorilla/handlers	0.224s

@elithrar elithrar self-assigned this Apr 16, 2018
@elithrar elithrar merged commit 2b8556b into master Apr 16, 2018
@elithrar
Copy link
Contributor Author

elithrar commented Apr 16, 2018

Need to resolve why this broke after merging, but did not before.

@elithrar elithrar deleted the elithrar/revert-cors-pr-114 branch April 16, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@elithrar elithrar

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elithrar