Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump version to final 1.16.0 #16966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

Bump version to final 1.16.0 #16966

merged 2 commits into from
Oct 23, 2018

Conversation

@stanley-cheung
Copy link
Contributor

Bump version to the final 1.16.0

@stanley-cheung stanley-cheung added the release notes: no Indicates if PR should not be in release notes label Oct 22, 2018
srini100
srini100 approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@srini100 srini100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
  -0.0%     -21 [None]                          -109  -0.0%
 -11.5%     -11 src/cpp/common/version_cc.cc     -11 -11.5%
     -22.0%     -11 grpc::Version[abi:cxx11]         -11 -22.0%

  -0.0%     -32 TOTAL                           -120  -0.0%

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,965,319      Total (<)      1,965,329

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,888,228      Total (=)     10,888,228

 No significant differences in binary sizes

@grpc-testing
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@JimmyCYJ JimmyCYJ mentioned this pull request Oct 23, 2018
Merged
@stanley-cheung stanley-cheung merged commit 98457b7 into grpc:v1.16.x Oct 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@srini100 srini100 srini100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stanley-cheung @grpc-testing @srini100