Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@markdroth
Copy link
Member

No description provided.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Oct 13, 2021
@markdroth markdroth requested a review from veblush October 13, 2021 16:56
@veblush
Copy link
Contributor

veblush commented Oct 13, 2021

Just out of curiosity, why do we need this upgrade? I upgraded it to the latest a week ago; #27606.

@markdroth
Copy link
Member Author

I'm the release manager for the gRPC 1.42 release, and upgrading boringssl is one of the release steps the week before the branch cut. If I'd known that you just upgraded it a week ago, I might not have bothered, but since I've already done this, we might as well get it merged.

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@markdroth
Copy link
Member Author

Known issues: #27603

The other failures are infrastructure issues.

@markdroth markdroth merged commit a542438 into grpc:master Oct 14, 2021
@markdroth markdroth deleted the boringssl_upgrade branch October 14, 2021 17:23
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 14, 2021
dennycd pushed a commit to dennycd/grpc that referenced this pull request Oct 15, 2021
* update submodule boringssl-with-bazel with origin/main-with-bazel

* update build files

* generate boringssl prefix headers

* update podspecs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imported Specifies if the PR has been imported to the internal repository release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants