Fix leased socket counting in socketpool #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d request cancelling.
Member
|
@i110 Please review and merge if it looks good to you. |
Contributor
|
Sorry for being late. The fix itself looks good for me, OTOH I don't understand why https://github.com/zlm2012/h2o/blob/9c0eaf065c633c69d4e23dd992807a93252a4594/lib/common/socketpool.c#L306 counts up only when |
Contributor
Author
|
Well it just because there's no reason to use a balancer if there's only one backend. But of course that would cause socket counting strange, so I will handle it. |
Contributor
Author
|
Sorry for the belated update. The lease counting should be correct now. |
Contributor
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leased socket counting for targets becomes wrong when pooled sockets are reused or connection is cancelled, which would cause least connection load balancer not quite right. This PR fix those places.