Invalid status json with multiple status endpoints #1807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deweerdt
reviewed
Jul 11, 2018
| h2o_config_register_status_handler(conf->global, requests_status_handler); | ||
| h2o_config_register_status_handler(conf->global, events_status_handler); | ||
| h2o_config_register_status_handler(conf->global, durations_status_handler); | ||
| if (!handler_registered) { |
Member
There was a problem hiding this comment.
Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?
Contributor
Author
There was a problem hiding this comment.
I think this case shoud not raise an error.
For my case, I want to serve same status for an internal domain and an external domain with access control.
Member
There was a problem hiding this comment.
Sorry, i meant the else case for this: otherwise we're simply silently ignoring invalid configuration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following config produce invalid duplicated json: