Add a helper to provide a prometheus endpoint #1831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two parts to this PR: - we annotate existing stats as 'gauge', so that we can default all other stats as 'counter' - we add an mruby helper and associated doc that consumes a status hander to produce stats in a Prometheus format
Member
Author
|
@yannick i would like to hear your thoughts as well |
Member
|
LGTM. I'll add links from configure.html and merge. |
Contributor
|
i just saw this now, cool! |
Merged
Contributor
|
close this because this functionality is rewritten by #1892 and it was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two parts to this PR:
other stats as 'counter'
hander to produce stats in a Prometheus format