Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add header flags #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 17, 2018
Merged

add header flags #1832

merged 8 commits into from
Aug 17, 2018

Conversation

@i110
Copy link
Contributor

@i110 i110 commented Aug 16, 2018 •
edited
Loading

This PR aims to

  1. allow us to set these flags per request basis (ex: dont_compress)
  2. refactor and reduce h2o_iovec_is_token calls

@i110 i110 force-pushed the i110/header-flags branch from f485e1e to 10c26af Compare August 16, 2018 09:08
@i110 i110 force-pushed the i110/header-flags branch from 10c26af to 3a8b663 Compare August 16, 2018 13:48
@i110 i110 changed the title [WIP] add header flags add header flags Aug 16, 2018
kazuho
kazuho reviewed Aug 16, 2018
View reviewed changes
@i110 i110 force-pushed the i110/header-flags branch from 7f36984 to e55fd1b Compare August 16, 2018 22:19
kazuho
kazuho reviewed Aug 16, 2018
View reviewed changes
@i110 i110 force-pushed the i110/header-flags branch from 291956b to f7402bc Compare August 16, 2018 23:55
@i110 i110 force-pushed the i110/header-flags branch from f7402bc to 00ccdd4 Compare August 16, 2018 23:57
@i110 i110 force-pushed the i110/header-flags branch from 0adafec to 7323893 Compare August 17, 2018 01:58
kazuho
kazuho reviewed Aug 17, 2018
View reviewed changes
Copy link
Member

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. Just some nitpicks... please let me know what you think.

@kazuho
Copy link
Member

kazuho commented Aug 17, 2018

You have my 👍 for 9b862da. Please feel free to merge if you think that the PR is ready.

@i110 i110 merged commit d890ee7 into master Aug 17, 2018
@kazuho kazuho mentioned this pull request Nov 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazuho kazuho kazuho left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@i110 @kazuho