send TLS alert on handshake failure when recent versions of OpenSSL is used #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@robguima Would you mind final-reviewing the changes? |
robguima
approved these changes
Oct 10, 2018
…lly emit an alert when handshake fails
eae7d98 to
05295c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has turned out that H2O has stopped sending TLS alerts upon handshake failure, when a recent version of OpenSSL is being used (the issue known to happen in 1.1.0g, but not in 1.1.0d). See
#1865 (comment) for how it happens.
This PR brushes up the fix proposed in #1865 as well as adding a test.