socketpool: refine pool entry timeout #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Feb 7, 2019
Member
kazuho
left a comment
There was a problem hiding this comment.
This looks awesome. Until reading the PR, I hadn't realized the fact that we could eliminate the inefficiency by using the timerwheel.
The code looks fine modulo the issue below.
lib/common/socketpool.c
Outdated
| __sync_sub_and_fetch(&pool->_shared.pooled_count, 1); | ||
| } | ||
| } | ||
| return SIZE_MAX; |
Contributor
Author
There was a problem hiding this comment.
Yes, should be UINT64_MAX for 32 bit system.
lib/common/socketpool.c
Outdated
| static void check_pool_expired_locked(h2o_socketpool_t *pool) | ||
| { | ||
| uint64_t next_expired = destroy_expired_locked(pool); | ||
| if (next_expired != SIZE_MAX) { |
Member
|
Thank you for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try calculating the exact timeout for socketpool's pool entry.