update picohttpparser and reject multiline headers #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Dec 20, 2018
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM modulo some nit-picking comments. Please let me know what you think.
lib/common/http1client.c
Outdated
| for (i = 0; i != num_headers; ++i) { | ||
| if (src_headers[i].name_len == 0) { | ||
| /* reject multiline header */ | ||
| on_error_before_head(client, "received multiline header that is not allowed"); |
Member
There was a problem hiding this comment.
"line folding of header fields is not supported"?
lib/http1.c
Outdated
| static void send_bad_request(struct st_h2o_http1_conn_t *conn, const char *body) | ||
| { | ||
| if (body == NULL) | ||
| body = "Bad Request"; |
Member
There was a problem hiding this comment.
Can we consistently specify the body on the call side?
Contributor
Author
6d49b7b to
cfdbb3c
Compare
Member
|
LGTM!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add the following three changes:
GET HTTP/1.1\r\n\r\n)/ HTTP/1.1\r\n\r\n)