fix compiler error under android O #1961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: control may reach end of non-void function [-Werror,-Wreturn-type]
kazuho
reviewed
Feb 7, 2019
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for the PR.
Could we resolve the issue by changing assert to h2o_fatal (because the latter is called even when NBEBUG is set and because it has the no-return attribute).
I am hesitant to adding code (it's a complexity!) that newer runs just to suppress compiler warnings.
Contributor
Author
|
Fixed according to your comments. |
Member
|
Thank you for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: control may reach end of non-void function
[-Werror,-Wreturn-type]