Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve documentation about extension property #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

Improve documentation about extension property #2047

merged 1 commit into from
May 13, 2019

Conversation

@smartmic
Copy link
Contributor

@smartmic smartmic commented May 9, 2019

It took me a while to find out about the default value for the extension property of the file-custom-handler. That's why I added some relevant documentation.

@utrenkner
Copy link
Contributor

utrenkner commented May 10, 2019

Thank you @smartmic ! Just this week, I tried to achieve exactly this, following this old @kazuho answer. But the default was missing.

Fortunately, I only had to deal with two shell scripts. I suffixed them with .cgi for which I defined fastcgi as custom handler.

@kazuho
Copy link
Member

kazuho commented May 13, 2019

Nice catch! Seems like #1414 introduced "default" but the documentation was not updated.

@kazuho kazuho merged commit 1e84d2c into h2o:master May 13, 2019
kazuho added a commit that referenced this pull request May 13, 2019
@kazuho
Merge pull request #2047
9de83a4 
Improve documentation about extension property
@smartmic smartmic deleted the improve-fastcgi-documentation branch May 13, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartmic @utrenkner @kazuho