Add an h2o_now_nanosec() func to the Event Loop API #2053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For clarity. Especially now that we have a now_ns variable.
kazuho
reviewed
May 13, 2019
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for the PR. Looks ready to merge modulo the comments below.
Member
|
Thank you for the changes. Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To gain better insight into the event loop latency. Nanosecond granularity will be useful.
How
now_nanosecmember toh2o_evloop_t, alongside the existingnownow_nanosecfirst, and then derivenowFor libuv, simply call the uv_hrtime function as suggested in their documentationExtra
Rename
nowtonow_millisecfor clarity at a glance.