Keep track of mmap failures #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Jun 4, 2019
lib/handler/status/events.c
Outdated
| " \"http2.write-closed\": %" PRIu64 ", \n" | ||
| " \"ssl.errors\": %" PRIu64 "\n", | ||
| " \"ssl.errors\": %" PRIu64 ", \n" | ||
| " \"memory.mmap_errors\": %" PRIu64 "\n", |
Member
There was a problem hiding this comment.
Let's use %zu instead of casting to uint64_t and using PRIu64.
The alternative is to change the type of mmap_errors to uint64_t, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for uint64_t.
kazuho
reviewed
Jun 5, 2019
include/h2o/memory.h
Outdated
| void h2o_append_to_null_terminated_list(void ***list, void *element); | ||
|
|
||
| extern __thread h2o_mem_recycle_t h2o_mem_pool_allocator; | ||
| extern size_t mmap_errors; |
Member
There was a problem hiding this comment.
Ahh my bad, we need h2o_ prefix. LGTM other than that.
Member
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Maintain a count of mmap failures, and make it accessible through the H2O Status API.
How
Declare a global
size_tand operate on it using the__sync_add_and_fetchatomic built-in function. Code is added to a hot function but given that the error is rare, there should be no performance impact.Demonstration
Native Response:
Prometheus Response via mruby: