[proxy] Forward broken chunk encoding upstream responses #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, H2O would send an empty body to the client, if upstream sent chunked response headers but no response body. This fixes it by checking that we've at least received one byte when deciding whether to treat connection close as an error or not Credit to @robguima for the finding and analysis
kazuho
reviewed
Jun 20, 2019
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM modulo a suggestion of an editorial refinement, please see below.
lib/common/http1client.c
Outdated
| client->bytes_to_consume = 0; | ||
| client->sock->bytes_read = client->sock->input->size; | ||
| if (reader == on_req_chunked) | ||
| client->_seen_at_least_one_chunk = 0; |
Member
There was a problem hiding this comment.
Do we need to initialize _seen_at_least_one_chunk here?
It is my understanding that all the members of h2o_http1client_t (with the exception of super) is zero-cleared when initialized in setup_client.
Assuming that, I might prefer setting this here to avoid confusion.
Member
Author
There was a problem hiding this comment.
Yes, good call, we don't need the initialization here, fixing
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, H2O would send an empty body to the client, if upstream
sent chunked response headers but no response body. This fixes it by
checking that we've at least received one byte when deciding whether to
treat connection close as an error or not
Credit to @robguima for the finding and analysis