expose bytes_written information of httpclient #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bec3b4f to
1a56bd3
Compare
kazuho
reviewed
Jul 12, 2019
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for the PR. Looks fine modulo the points below.
kazuho
approved these changes
Jul 12, 2019
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for the changes. Please merge once the CI succeeds.
This was referenced Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user of httpclient occasionally wants to know how much the actually bytes written (for header, body and total) to the upstream. This PR expose that information.
Regarding http2client, it is controversial that what size should be exposed via this API. Is summation of actual written size of HEADERS or DATA frame, including frame headers?NOTE: I decided to implement the same feature on http2client, when it is actually needed by someone :)
- [ ] http2client