make sock->bytes_read cumulative #2240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Jan 28, 2020
Member
kazuho
left a comment
There was a problem hiding this comment.
Thank you for working on the fix. LGTM modulo the point below.
kazuho
approved these changes
Jan 28, 2020
Member
kazuho
left a comment
There was a problem hiding this comment.
LGTM Please merge once CI succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2197
As #2197 (comment) stated,
sock->bytes_readwas contradicting to the API comment: it was delta from previous callback invocation, not total value. This PR makes it be real total size of bytes the socket ever read.