send TLS alert before closing the socket, when OpenSSL is used and certificate verification fails #2910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the old comment being removed in this PR, OpenSSL as of 1.1.0 emits TLS alert inside
SSL_acceptwhen handshake the handshake fails, andSSL_shutdownreturns an error when being called afterwards.Our fix (#1872) to this change of behavior has been to check if there's anything in the output buffer, when
SSL_acceptorSSL_connectreturns an error. If there's something, we'd delay the invocation ofon_handshake_completeuntil the output is written to the socket.However, the fix did not cover the case when
verify_resultis notX509_V_OK. Hence the problem as stated in the title of this PR.Whatever the fix is, it should use one approach for handling all handshake errors.