@achanda Are we detecting versions of rkt in the fingerprinter? Hope this won't work with older versions of rkt?

@diptanu updated the min rkt version check. This indeed won't work on earlier versions. Thanks for pointing this out.

@achanda Changes looks fine to me. I think we might need to be a little serious about maintaining backward compatibility here. So if a user rolls this new nomad client on a machine Nomad won't be able to schedule any new jobs on the node until the operator drains the node and upgrades the rkt driver. I think we should maintain compatibility with at least the last 2-3 versions of rkt.

Is it possible for us to detect the version and based on the version add the appropriate flags?

@diptanu that's certainly possible. Let's hold off this PR for now and I can work on it.

@achanda Thanks!

@diptanu trying to implement what we discussed here. How do I get the version of the driver? The Fingerprint method puts it in node.Attributes, but how do I query it?

@achanda You mean version of the rkt binary? You could get the versions in the Start method via d.config.Node.Attributes["driver.rkt.version"] and d.config.Node.Attributes["driver.rkt.appc.version"]

Hope this helps?

@achanda Any update on this?

@diptanu sorry, I pushed a PR now. This still needs some work, d.config.Node.Attributes["driver.rkt.version"] gives me a runtime panic.

Closing this PR since this hasn't been worked on for a really long time. Please re-open the PR once again if you plan to finish the work.

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.