Add unsnoc to Data.Text and Data.Text.Lazy
#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvr
added a commit
that referenced
this pull request
Dec 17, 2017
hvr
added a commit
to text-utf8/text-utf8
that referenced
this pull request
May 13, 2018
(cherry picked from commit acf5018)
strake
pushed a commit
to strake/text.hs
that referenced
this pull request
Feb 28, 2021
(cherry picked from commit acf5018)
strake
pushed a commit
to strake/text.hs
that referenced
this pull request
Mar 2, 2021
(cherry picked from commit acf5018)
strake
pushed a commit
to strake/text.hs
that referenced
this pull request
Mar 2, 2021
(cherry picked from commit acf5018)
strake
pushed a commit
to strake/text.hs
that referenced
this pull request
Mar 2, 2021
(cherry picked from commit acf5018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171.
(I don't understand the streaming/fusion side of things well enough to add them, or the inline stages well enough to set a good level, unfortunately. The simple but probably suboptimal Lazy unsnoc is more or less copied from ByteString; I think it makes sense because the operation is inherently slow and you'd probably avoid it in performance-sensitive code anyway.)