Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor libcnb_package::cross_compile_assistance #727

@edmorley

Description

@edmorley

I think we should make the following changes to cross_compile_assistance():

  • Make it return a Result<Config, CrossCompileConfigError> instead of the three-state CrossCompileAssistance enum, where some of the states really should be errors. (The call site can still choose to ignore the errors if eg --no-cross-compile-assistance is used.)
  • De-duplicate the help text
  • Stop ignoring I/O errors that occur when using which (other than not found errors)

See:
https://github.com/heroku/libcnb.rs/blob/main/libcnb-package/src/cross_compile.rs

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions