Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(load_config): enforce stricter extension checks #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

feat(load_config): enforce stricter extension checks #5591

merged 1 commit into from
May 3, 2025
+7 −5

Conversation

@stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Dec 22, 2024 •
edited
Loading

What does it do?

I've noticed that Hexo supports searching for configuration files with different suffixes, such as _config.txt and _config.json. However, this check is very loose, meaning that _config.backup or _config.yml.bak are also considered valid configuration files. This feature can cause confusion and even security issues for users. Therefore, I refactor this feature in the pull request.

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b config https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

SukkaW
SukkaW requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer to automatically choose config.yml or config.json without specifying it. We might wanna make findConfigPath more strict though.

@stevenjoezhang stevenjoezhang changed the title feat(load_config): remove findConfigPath feat(load_config): enforce stricter extension checks Dec 23, 2024
@stevenjoezhang
Copy link
Member Author

@SukkaW I've updated the code, and now the JSON suffix is also supported.

SukkaW
SukkaW requested changes Dec 24, 2024
View reviewed changes
@stevenjoezhang stevenjoezhang requested a review from SukkaW April 18, 2025 17:36
@coveralls
Copy link

coveralls commented Apr 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14597269367

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.525%
Totals Coverage Status
Change from base Build 14597018384: 0.0%
Covered Lines: 9857
Relevant Lines: 9904
💛 - Coveralls

yoshinorin
yoshinorin approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@stevenjoezhang stevenjoezhang merged commit 80b6cd1 into master May 3, 2025
24 checks passed
@stevenjoezhang stevenjoezhang deleted the config branch May 3, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW Awaiting requested review from SukkaW

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevenjoezhang @coveralls @yoshinorin @SukkaW