Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Izone component #24550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 19, 2019
Merged

Izone component #24550

merged 22 commits into from
Sep 19, 2019

Conversation

@Swamp-Ig
Copy link
Contributor

@Swamp-Ig Swamp-Ig commented Jun 15, 2019 •
edited
Loading

Description:

New integration for the iZone climate control system.

I have had this as a custom component for some time and have a few existing users. I though it was time to integrate it. It should be pretty solid as it's reasonably well tested.

The translations were basically copied from the daikin component, just changing the names to iZone, so they should be correct.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9635

Example entry for configuration.yaml (optional, uses config entries):

izone:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@Swamp-Ig Swamp-Ig mentioned this pull request Jun 15, 2019
Merged
2 tasks
OttoWinter
OttoWinter reviewed Jun 15, 2019
View reviewed changes
@Nick-Adams-AU
Copy link
Contributor

Nick-Adams-AU commented Jun 21, 2019

Is this able to be merged now?

MartinHjelmare
MartinHjelmare requested changes Jun 22, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All PRs that have climate platforms are blocked by climate 1.0 PR unfortunately.

See other comments below.

@home-assistant home-assistant deleted a comment Jun 25, 2019
@Nick-Adams-AU
Copy link
Contributor

Nick-Adams-AU commented Jul 16, 2019

I have been running this on 0.95 and haven't had any issues. Now that the Climate 1.0 PR has been merged, are we able to merge this component?

@frenck
Copy link
Member

frenck commented Jul 16, 2019

@Nick-Adams-AU The current state will not work on 0.96.

This integration needs to be updated for Climate 1.0 first and some comments are still open that need to be addressed as well.

@Swamp-Ig
Copy link
Contributor Author

Swamp-Ig commented Jul 31, 2019

Updated now to Climate 1.0, and addressed all comments. I need to do some tests for the config flow.

@gavc1
Copy link

gavc1 commented Aug 5, 2019

Thanks swamp, I have been testing this and noticed the controller status does not match in home assistant.
EG the Aircon is on, but shows off in Home Assistant.
I did notice this in my logs if it helps
Exception in _controller_discovered when dispatching 'izone_controller_discovered': (<pizone.controller.Controller object at 0xb2586990>,)
Traceback (most recent call last):
File "/config/custom_components/izone/discovery.py", line 40, in _controller_discovered
"discovered device that already exists"
AssertionError: discovered device that already exists

@gavc1
Copy link

gavc1 commented Aug 5, 2019

Thanks swamp, I have been testing this and noticed the controller status does not match in home assistant.
EG the Aircon is on, but shows off in Home Assistant.
I did notice this in my logs if it helps
Exception in _controller_discovered when dispatching 'izone_controller_discovered': (<pizone.controller.Controller object at 0xb2586990>,)
Traceback (most recent call last):
File "/config/custom_components/izone/discovery.py", line 40, in _controller_discovered
"discovered device that already exists"
AssertionError: discovered device that already exists

Don't worry, I removed the integration and re set it up using the config flow and it all works well now.

MartinHjelmare
MartinHjelmare requested changes Aug 6, 2019
View reviewed changes
@Swamp-Ig
Copy link
Contributor Author

Swamp-Ig commented Aug 7, 2019

All comments now addressed, and the test case exists.

MartinHjelmare
MartinHjelmare reviewed Aug 7, 2019
View reviewed changes
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Aug 7, 2019

There are still comments in the previous review that haven't been addressed.

@Nick-Adams-AU
Copy link
Contributor

Nick-Adams-AU commented Aug 26, 2019

Is it just the tests that are holding up this merge?

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Aug 26, 2019

There are at least four comments left to address.

@Nick-Adams-AU
Copy link
Contributor

Nick-Adams-AU commented Sep 2, 2019

Hey @Swamp-Ig. Thanks for your work on this so far! Is there a way to pay/sponsor your work to complete the integration of this component?

@Swamp-Ig
Copy link
Contributor Author

Swamp-Ig commented Sep 4, 2019 •
edited
Loading

I'm pretty short on spare time at the moment, my one day a week was taken up with other stuff both this week and last. Will see what I can do next Wednesday. Got a lot of demands on my time currently, it's not a financial thing.

@Swamp-Ig
Copy link
Contributor Author

Swamp-Ig commented Sep 18, 2019

Test case is complete and all comments now addressed AFAICS

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Sep 18, 2019 •
edited
Loading

There are still four comments left to address:
#24550 (comment)

#24550 (comment)

#24550 (comment)

#24550 (comment)

Make sure to load all comments to be able to see them. Github collapses comments in desktop view when the thread gets too long.

MartinHjelmare
MartinHjelmare reviewed Sep 18, 2019
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit b68b843 into home-assistant:dev Sep 19, 2019
ochlocracy pushed a commit to ochlocracy/home-assistant that referenced this pull request Sep 30, 2019
@Swamp-Ig @ochlocracy
Izone component (home-assistant#24550)
0bdfe14 
* iZone component

* Rename constants to const.

* Changes as per code review.

* Stop listening if discovery times out.

* Unload properly

* Changes as per code review

* Climate 1.0

* Use dispatcher instead of listener

* Free air settings

* Test case for config flow.

* Changes as per code review

* Fix error on shutdown

* Changes as per code review

* Lint fix

* Black formatting

* Black on test

* Fix test

* Lint fix

* Formatting

* Updated requirements

* Remaining patches

* Per code r/v
ochlocracy pushed a commit to ochlocracy/home-assistant that referenced this pull request Oct 1, 2019
@Swamp-Ig @ochlocracy
Izone component (home-assistant#24550)
154526b 
* iZone component

* Rename constants to const.

* Changes as per code review.

* Stop listening if discovery times out.

* Unload properly

* Changes as per code review

* Climate 1.0

* Use dispatcher instead of listener

* Free air settings

* Test case for config flow.

* Changes as per code review

* Fix error on shutdown

* Changes as per code review

* Lint fix

* Black formatting

* Black on test

* Fix test

* Lint fix

* Formatting

* Updated requirements

* Remaining patches

* Per code r/v
@balloob balloob mentioned this pull request Oct 9, 2019
Merged
@teaching-innovation
Copy link

teaching-innovation commented Oct 10, 2019

Haven’t tested yet but excited to see iZone component released in V 0.100. Great work @swamp-lg for all your hard work.

@teaching-innovation
Copy link

teaching-innovation commented Oct 10, 2019

I have just tested. I moved from V0.93 to V0.100.0b3. It works for mode and fan speed but I am unable to set the "temp_setpoint: 23" from home assistant.

The UI in lovelace also lacks the ability to set the temperature as it is greyed out.
image
image

@frenck
Copy link
Member

frenck commented Oct 10, 2019

@teaching-innovation Please don't use PR's to discuss issues, instead, create a new issue on GitHub. That allows us to track it. Thanks 👍

@Swamp-Ig Swamp-Ig deleted the izone-component branch August 24, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OttoWinter OttoWinter OttoWinter left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

cla-signed integration: izone new-integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Swamp-Ig @Nick-Adams-AU @frenck @gavc1 @MartinHjelmare @teaching-innovation @OttoWinter @homeassistant