Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Sep 19, 2019

Description:

Bumps aiohttp to 3.6.0

Changelog: https://github.com/aio-libs/aiohttp/releases/tag/v3.6.0

Unit tests have been updated to be compatible with this release.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added core has-tests small-pr PRs with less than 30 lines. labels Sep 19, 2019
@frenck frenck marked this pull request as ready for review September 19, 2019 15:27
@frenck frenck requested a review from a team as a code owner September 19, 2019 15:27
@pvizeli
Copy link
Member

pvizeli commented Sep 19, 2019

Before we can merge:

  • Test Ingress
  • Test RemoteSNI SocketSite injection
  • Test application freeze on discovery
  • Test mjpeg stream
  • Test Hass.io API proxy

@frenck
Copy link
Member Author

frenck commented Sep 19, 2019

  • Tested mjpeg stream, works fine.
  • All my devices on my home network are discovered in a timely fashion.
  • TTS works.
  • Tested with Nabu Casa Remote UI (including mjpeg stream).

@pvizeli pvizeli merged commit a8a485a into dev Sep 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0186 branch September 19, 2019 18:34
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants