Bump adb-shell to 0.0.4; bump androidtv to 0.0.30 #27224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improve support for newer devices using the Python ADB implementation (as opposed to the ADB server approach).
Related issue (if applicable): This fixes a bug where the ADB connection attempt would fail but
adb-shellwould incorrectly report toandroidtvthat the connection was available, and whenandroidtvwould send an ADB command it would cause an exception. With this fix in place, if the ADB connection attempt fails then aPlatformNotReadyexception will be raised, which is the desired behavior.This also applies to the case that a re-connect attempt fails, which could occur during a reboot of the device.
Any chance this bug fix could be included in 0.100?
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all.