Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JeffLIrion
Copy link
Contributor

@JeffLIrion JeffLIrion commented Oct 5, 2019

Description:

Improve support for newer devices using the Python ADB implementation (as opposed to the ADB server approach).

Related issue (if applicable): This fixes a bug where the ADB connection attempt would fail but adb-shell would incorrectly report to androidtv that the connection was available, and when androidtv would send an ADB command it would cause an exception. With this fix in place, if the ADB connection attempt fails then a PlatformNotReady exception will be raised, which is the desired behavior.

This also applies to the case that a re-connect attempt fails, which could occur during a reboot of the device.

Any chance this bug fix could be included in 0.100?

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@probot-home-assistant probot-home-assistant bot added integration: androidtv small-pr PRs with less than 30 lines. labels Oct 5, 2019
@JeffLIrion JeffLIrion marked this pull request as ready for review October 5, 2019 17:41
@balloob balloob merged commit 0b838f8 into home-assistant:dev Oct 5, 2019
@JeffLIrion
Copy link
Contributor Author

@balloob thanks! Any chance this could be included in 0.100?

@balloob balloob added this to the 0.100 milestone Oct 5, 2019
@lock lock bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants