Add a cache for MakePixelsTexture #17534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, discovered I forgot some barriers on Vulkan. Will fix later today - but doesn't seem to affect it in practice on the devices I tried on. |
hrydgard
added a commit
that referenced
this pull request
May 30, 2023
Vulkan image barrier fix, image leak fix from #17534
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to not recreate the textures every frame for the purposes of DrawPixels, instead reuse them from previous frames. We don't use textures from the last 3 frames to be sure (should actually check the buffered frame count, perhaps).
We're still quite aggressive at garbage collecting these for now, currently after 10 frames but can easily tweak.
Previously we couldn't update the content of thin3d textures, but I've now added a path to do that.
Basically, it turns out that creating/destroying textures in Vulkan was more expensive than I thought, and in God of War which does a lot of DrawPixels for whatever reason, this is a really good speed boost, at least on PC, I'm seeing 20%. Working smoothly on mobile, too.
D3D11 implementation still missing, so draft.