Thanks to visit codestin.com
Credit goes to github.com

Skip to content

We somehow lost the usage_ counter increment in VulkanDescSetPool, fix that #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

We somehow lost the usage_ counter increment in VulkanDescSetPool, fix that #18332

merged 1 commit into from
Oct 9, 2023

Conversation

@hrydgard
Copy link
Owner

@hrydgard hrydgard commented Oct 9, 2023

This caused assorted problems depending on the driver, but always including spamming of resets once there's more than 512 descriptors.

Also remove a unused decimation counter.

@hrydgard hrydgard added the Vulkan label Oct 9, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Oct 9, 2023
@hrydgard hrydgard merged commit ef35cbb into master Oct 9, 2023
@hrydgard hrydgard deleted the desc-set-fix branch October 9, 2023 15:34
@master1274
Copy link

Shield Tablet 32GB/LTE, Tegra K-1, Android 7.0, ARMv7, 320 dpi(1920х1200), OpenGL ES 3.2, Vulkan 1.0, Core 4x ARM Cortex-A15 - 2218 MHz.
I didn't understand if there should have been a fix v1.16.5-168-gef35cbbed fix the job Vulkan, which appeared in v1.16.5-153-g43cdb88ac, but it still doesn’t work on my device, it closes with an error. Only works GL. On the latest build v1.16.5-178-g35fcec1e4 the same

@hrydgard
Copy link
Owner Author

Hm, thanks for reporting that it's still broken. I have a similar device that I'll try to test on soon.

@hrydgard hrydgard mentioned this pull request Oct 10, 2023
Merged
@hrydgard
Copy link
Owner Author

Alright, fix underway.

@hrydgard
Copy link
Owner Author

Turns out it was never there, so VulkanDescSetPool has been working suboptimally for some time:

1010d7a#diff-d5891ac45357a62cd705896d2ed1d0e65f635e49040cc6803c519cd5543d6a3cR152

@unknownbrackets
Copy link
Collaborator

Oops. And I made sure to set it to zero in so many places...

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Vulkan

Projects

None yet

Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hrydgard @master1274 @unknownbrackets