Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch the recent files manager to the "command processor on thread" pattern, to avoid blocking the main thread #20163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Switch the recent files manager to the "command processor on thread" pattern, to avoid blocking the main thread #20163

merged 3 commits into from
Mar 26, 2025

Conversation

@hrydgard
Copy link
Owner

This removes all instances (except join-thread-on-quit) where the main thread was previously waiting for the cleaning of the recents list and similar.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Mar 26, 2025
@hrydgard hrydgard added this to the v1.19.0 milestone Mar 26, 2025
@hrydgard
Switch the recent files manager to the "command processor on thread" …
6ea0dd8 
…pattern

This removes all instances (except join-thread-on-quit) where the main
thread was previously waiting for the cleaning of the recents list and
similar.
@hrydgard hrydgard force-pushed the refactor-recent-files branch from 39b9281 to 6ea0dd8 Compare March 26, 2025 20:31
@hrydgard hrydgard merged commit f73df3a into master Mar 26, 2025
19 checks passed
@hrydgard hrydgard deleted the refactor-recent-files branch March 26, 2025 23:00
@Unknowncat1991
Copy link

I cannot open ppsspp staring with this build :(

XRecorderLite_27032025_082351.mp4 
pid: 13528, tid: 13552, name: RecentISOs  >>> org.ppsspp.ppsspp <<<

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #04 pc 000000000092ae10  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (HandleAssert(char const*, char const*, int, char const*, char const*, ...)+388) (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #05 pc 000000000093a120  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (getEnv()+112) (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #06 pc 00000000008c433c  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (Android_FileExists(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)+32) (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #07 pc 00000000008ca79c  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (File::Exists(Path const&)+108) (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #08 pc 0000000000748744  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (RecentFilesManager::PerformCleanMissing()+272) (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #09 pc 0000000000747a38  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (RecentFilesManager::ThreadFunc()+468) (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.482 14028:14028 F/DEBUG]
      #10 pc 0000000000748f5c  /data/app/~~7ynrhkhFjuVUlvzJdB0PYg==/org.ppsspp.ppsspp-ldRjD0HKYggBw9mxVffgTA==/lib/arm64/libppsspp_jni.so (BuildId: c60042e40dc7b9bba2c914b5ade2a4302645fa06)

[03-27 08:20:10.736 944:944 I/BufferQueueDebug]
[SurfaceView[org.ppsspp.ppsspp/org.ppsspp.ppsspp.PpssppActivity](BLAST)#0](this:0xb4000076c650b8d0,id:-1,api:0,p:-1,c:944) onDestructor()

[03-27 08:20:10.737 944:944 I/BufferQueueDebug]
[SurfaceView[org.ppsspp.ppsspp/org.ppsspp.ppsspp.PpssppActivity](BLAST)#0](this:0xb4000077719808d0,id:-1,api:0,p:-1,c:944) onDestructor()

[03-27 08:20:10.738 944:944 I/BufferQueueDebug]
[org.ppsspp.ppsspp/org.ppsspp.ppsspp.PpssppActivity#0](this:0xb4000076c66658d0,id:-1,api:0,p:-1,c:944) onDestructor()

[03-27 08:20:10.740 944:944 I/BufferQueueDebug]
[SurfaceView[org.ppsspp.ppsspp/org.ppsspp.ppsspp.PpssppActivity](BLAST)#0](this:0xb4000076c66898d0,id:-1,api:0,p:-1,c:944) onDestructor()

[03-27 08:20:10.997 944:1093 E/BufferQueueDebug]
[Application Error: org.ppsspp.ppsspp#0](this:0xb4000076c12228d0,id:-1,api:0,p:-1,c:-1) id info cannot be read from 'Application Error: org.ppsspp.ppsspp#0'

[03-27 08:20:10.997 944:1093 I/BufferQueueDebug]
[Application Error: org.ppsspp.ppsspp#0](this:0xb4000076c12228d0,id:-1,api:0,p:-1,c:-1) BufferQueue core=(944:/system/bin/surfaceflinger)

[03-27 08:20:11.354 944:944 I/BufferQueueDebug]
[Application Error: org.ppsspp.ppsspp#0](this:0xb4000076c12228d0,id:-1,api:0,p:-1,c:944) onDestructor()

@hrydgard
Copy link
Owner Author

fix coming up

@hrydgard hrydgard mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

User Interface PPSSPP's own user interface / UX

Projects

None yet

Milestone

v1.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@hrydgard @Unknowncat1991