Misc ImDebugger improvements #20294
Merged
Misc ImDebugger improvements #20294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is it more convenient to looked at zeroes with different color? since those zero byte could be a part of 16-bit or larger value. |
Contributor
Author
|
Yeah that's fair. |
hrydgard
approved these changes
Apr 27, 2025
Owner
hrydgard
left a comment
There was a problem hiding this comment.
Seems fine to me. I guess we could add more general value color schemes, but this is ok as-is.
Why left as draft?
Owner
|
Ping @quirkylemon |
Contributor
Author
|
sorry I was busy, I added a toggle just in case this isn't a universally helpful feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When reverse engineering it can be helpful for zeros to be drawn with a darker color so you can visually see the structure of data in ram.
The new color was basically just a random choice so feel free to change it.
I only found the small char array because of a compiler warning so it is very possible that nothing bad actually happens.