Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mqtt-tools/mqttshark
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: itsjfx/mqttshark
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 5, 2024

  1. parse less args and pass extras to tshark 

    * --interface is handled by tshark
* i've made --port handled by tshark as setting a filter if making
  tshark read from a file is not possible
* tls-keylog can just be set by the user using tshark syntax
    @itsjfx
    itsjfx committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    81a1fc5 View commit details
    Browse the repository at this point in the history

  2. iterate over stdout instead of while True

    @itsjfx
    itsjfx committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8bcfba0 View commit details
    Browse the repository at this point in the history

  3. fix process exit handling 

    * ignore keyboard interrupts
* wait for tshark after reading all of stdout, exit with correct code
* keep stderr as it contains info from tshark. stderr can always be
  redirected
    @itsjfx
    itsjfx committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a6d9a62 View commit details
    Browse the repository at this point in the history

  4. should pass

    @itsjfx
    itsjfx committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a54fc64 View commit details
    Browse the repository at this point in the history
Loading