Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 0ec1ec2

Browse files
committed
fix: add nosetter
1 parent d1a7186 commit 0ec1ec2

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

packages/Main/src/Layer/OGC3DTilesLayer.js

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,10 @@ export function enableMeshoptDecoder(MeshOptDecoder) {
145145
itownsGLTFLoader.setMeshoptDecoder(MeshOptDecoder);
146146
}
147147

148+
const noSetter = () => {
149+
console.warn('[OGC3DTilesLayer] Material property cannot be set from the material, use layer properties instead');
150+
};
151+
148152
/**
149153
* Patches material properties to automatically update the material (uniforms
150154
* and shader) when the layer properties are updated. Note that:
@@ -158,7 +162,7 @@ export function enableMeshoptDecoder(MeshOptDecoder) {
158162
function referMaterialProperties(material, layer) {
159163
Object.defineProperty(material, 'opacity', {
160164
get: () => layer.opacity,
161-
set: () => {},
165+
set: noSetter,
162166
});
163167

164168
let _transparent = material.transparent;
@@ -171,12 +175,12 @@ function referMaterialProperties(material, layer) {
171175
}
172176
return transparent;
173177
},
174-
set: () => {},
178+
set: noSetter,
175179
});
176180

177181
Object.defineProperty(material, 'wireframe', {
178182
get: () => layer.wireframe,
179-
set: () => {},
183+
set: noSetter,
180184
});
181185
}
182186

@@ -203,47 +207,47 @@ function referPointsMaterialProperties(material, layer) {
203207
}
204208
return transparent;
205209
},
206-
set: () => {},
210+
set: noSetter,
207211
});
208212

209213
Object.defineProperty(material, 'wireframe', {
210214
get: () => layer.wireframe,
211-
set: () => {},
215+
set: noSetter,
212216
});
213217

214218
Object.defineProperty(material.uniforms.opacity, 'value', {
215219
get: () => layer.opacity,
216-
set: () => {},
220+
set: noSetter,
217221
});
218222

219223
Object.defineProperty(material.uniforms.mode, 'value', {
220224
get: () => layer.pntsMode,
221-
set: () => {},
225+
set: noSetter,
222226
});
223227

224228
Object.defineProperty(material.uniforms.shape, 'value', {
225229
get: () => layer.pntsShape,
226-
set: () => {},
230+
set: noSetter,
227231
});
228232

229233
Object.defineProperty(material.uniforms.sizeMode, 'value', {
230234
get: () => layer.pntsSizeMode,
231-
set: () => {},
235+
set: noSetter,
232236
});
233237

234238
Object.defineProperty(material.uniforms.minAttenuatedSize, 'value', {
235239
get: () => layer.pntsMinAttenuatedSize,
236-
set: () => {},
240+
set: noSetter,
237241
});
238242

239243
Object.defineProperty(material.uniforms.maxAttenuatedSize, 'value', {
240244
get: () => layer.pntsMaxAttenuatedSize,
241-
set: () => {},
245+
set: noSetter,
242246
});
243247

244248
Object.defineProperty(material.uniforms.scale, 'value', {
245249
get: () => layer.scale,
246-
set: () => {},
250+
set: noSetter,
247251
});
248252
}
249253

0 commit comments

Comments
 (0)