fix(Style): dont draw icon when size is 0

ftoromanoff · ftoromanoff · commit 858b89e896b5 · 2025-01-15T10:28:29.000+01:00
diff --git a/src/Core/Style.js b/src/Core/Style.js
@@ -905,13 +905,13 @@ class Style {
                         }
                     }
                     style.icon.source = sprites.source;
-                    style.icon.size = readVectorProperty(layer.layout['icon-size']) || 1;
+                    style.icon.size = readVectorProperty(layer.layout['icon-size']) ?? 1;
                     const { color, opacity } = rgba2rgb(readVectorProperty(layer.paint['icon-color'], { type: 'color' }));
                     // https://docs.mapbox.com/style-spec/reference/layers/#paint-symbol-icon-color
                     if (iconImg.sdf) {
                         style.icon.color = color;
                     }
-                    style.icon.opacity = readVectorProperty(layer.paint['icon-opacity']) || (opacity !== undefined && opacity);
+                    style.icon.opacity = readVectorProperty(layer.paint['icon-opacity']) ?? (opacity !== undefined && opacity);
                 } catch (err) {
                     err.message = `VTlayer '${layer.id}': argument sprites must not be null when using layer.layout['icon-image']`;
                     throw err;

Original file line number	Diff line number	Diff line change
`@@ -905,13 +905,13 @@ class Style {`
`905`	`905`	`}`
`906`	`906`	`}`
`907`	`907`	`style.icon.source = sprites.source;`
`908`		`- style.icon.size = readVectorProperty(layer.layout['icon-size']) \|\| 1;`
	`908`	`+ style.icon.size = readVectorProperty(layer.layout['icon-size']) ?? 1;`
`909`	`909`	`const { color, opacity } = rgba2rgb(readVectorProperty(layer.paint['icon-color'], { type: 'color' }));`
`910`	`910`	`// https://docs.mapbox.com/style-spec/reference/layers/#paint-symbol-icon-color`
`911`	`911`	`if (iconImg.sdf) {`
`912`	`912`	`style.icon.color = color;`
`913`	`913`	`}`
`914`		`- style.icon.opacity = readVectorProperty(layer.paint['icon-opacity']) \|\| (opacity !== undefined && opacity);`
	`914`	`+ style.icon.opacity = readVectorProperty(layer.paint['icon-opacity']) ?? (opacity !== undefined && opacity);`
`915`	`915`	`} catch (err) {`
`916`	`916`	err.message = `VTlayer '${layer.id}': argument sprites must not be null when using layer.layout['icon-image']`;
`917`	`917`	`throw err;`