feat(protocols): add spatial hashing to StaticProvider #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using https://github.com/mourner/flatbush speeds up the look up by a factor of 10. For instance, on my computer and the panorama demo: - before the PR selectBestImageForExtent used to take 0.5ms to 3ms - after the PR: <= 0.1ms
autra
suggested changes
Mar 6, 2018
| } | ||
| layer._spatialIndex = FlatBush(layer.images.length); | ||
| for (const image of layer.images) { | ||
| layer._spatialIndex.add( |
Contributor
There was a problem hiding this comment.
You could merge this loop with the one above. Or did I miss something?
Contributor
Author
There was a problem hiding this comment.
I need to know the number of images to initialize the index.
And metadata is a json object, so I'm not sure how to get the number of images before the loop?
Contributor
There was a problem hiding this comment.
Oh right, it's a for..in, not a for..of loop
| for (const entry of layer.images) { | ||
| if (tile.extent.isInside(entry.extent)) { | ||
| return true; | ||
| if (tile.extent.crs() == layer.extent.crs()) { |
Contributor
There was a problem hiding this comment.
providing that Extent.isInside starts by doing other.as(this._crs), why can't we use the spatial index in all cases by doing a tile.extent.as(layer.extent.crs()) first?
Contributor
Author
There was a problem hiding this comment.
Ok, I'll change that.
autra
approved these changes
Mar 6, 2018
Contributor
|
LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/mourner/flatbush speeds up the look up by a factor of 10.
For instance, on my computer and the panorama demo: