IBX-10144: Implemented supported_media_types flag for REST requests
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
reviewed
Jun 16, 2025
tests/bundle/EventListener/XmlUnsupportedMediaTypeSubscriberTest.php
Outdated
Show resolved
Hide resolved
tests/bundle/EventListener/XmlUnsupportedMediaTypeSubscriberTest.php
Outdated
Show resolved
Hide resolved
xml_disabled flag for REST requestssupported_media_types flag for REST requests
48ac4f0 to
9b6507f
Compare
Contributor
Author
|
Not sure about SonarCloud report - we actually base our logic on user input to some degree, but this test proves that we catch such cases anyway. To me it's false positive but I am open for ideas how to improve things while not sacrificing SOLID approach here. |
alongosz
reviewed
Jun 16, 2025
5debcdf to
837c1c2
Compare
alongosz
approved these changes
Jun 16, 2025
adamwojs
approved these changes
Jun 16, 2025
alongosz
reviewed
Jun 24, 2025
6bbe537 to
2144d0d
Compare
2144d0d to
3ee7517
Compare
34e1d33 to
37dffc7
Compare
de23a92 to
c5b4c50
Compare
|
katarzynazawada
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Caution
PHPStan issues in the baseline are not related.
Note
Functional tests fail due to https://github.com/ibexa/rest/pull/178/files#diff-6960594afa3cea81857e6c8b0f3f664b619ac991945185c5b3938c42840162a4R44, added temporarily to check if CI lits green.
For QA:
Documentation: