Fullscreen fix #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work was done on YouTube: https://youtu.be/i3yVqWYFbCE The SDL3 headers are in the commit before this one, so as not to junk up this specific commit. This needs further work; I mentioned a few things in the video. At a minimum, the patch uses spaces instead of tabs, and that needs to be cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Please bear with me here I am new to this. never worked with SDL or Quake3 before. just wanted to learn.
This is a fix for the Fullscreen mode. it Seems that displayID 0 being passed in the SDL_DisplayMode when calling SDL_SetWindowFullscreenMode which causes error "Invalid Fullscreen display mode" .
In the code there are two solutions to this I saw it working. One takes in account any setting set and the other just queries windows for Fullscreen mode and choose it as the intended mode.
Thanks.